Add "omitRouter" option #421
Conversation
|
@supasate Anything I can do to help this along? |
|
Until this is merged, I have a fork of this package up at https://www.npmjs.com/package/@blackarctic/connected-react-router |
|
Bump |
|
@blackarctic. Sorry for delayed response. Is your higher-level Router a React Router? If no, it would be out of scope of this package that intends for using with React Router. If yes, I would like to understand a bit more why you can't use ConnectedRouter instead of that React Router. |
|
We are using Webpack 5 module federation. Thus the React Router is in the host application but each app is using its own Redux store with its own connected-react-router instance. |
|
That sounds good to me. Would you mind adding a comment telling the use case of this option? So, other people can understand its purpose. |
|
Sure. Preference on where? |
|
LGTM. Thanks for your contribution! |
This allows for the following configuration:
Currently, my team is running into this situation where
Routeris provided at a higher point in the architecture and we want to useconnected-react-routerwith our Redux store, but we needconnected-react-routerto use theRouterinstance that is higher up the tree instead of providing its own.This option is added as opt-in only and should not affect any existing usage.